Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/pnacl-freeze/pnacl-freeze.cpp

Issue 1151093004: Changes from 3.7 merge to files not in upstream (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/pnacl-freeze/pnacl-freeze.cpp
diff --git a/tools/pnacl-freeze/pnacl-freeze.cpp b/tools/pnacl-freeze/pnacl-freeze.cpp
index 3899c8e1c09238af7b8bd4665987f7d6327acacb..ea56ec3dbe092348d8295b1cec047d4690df2f2d 100644
--- a/tools/pnacl-freeze/pnacl-freeze.cpp
+++ b/tools/pnacl-freeze/pnacl-freeze.cpp
@@ -61,7 +61,7 @@ int main(int argc, char **argv) {
cl::ParseCommandLineOptions(argc, argv, "Generates NaCl pexe wire format\n");
std::string ErrorMessage;
- std::auto_ptr<Module> M;
+ std::unique_ptr<Module> M;
// Use the bitcode streaming interface
DataStreamer *streamer = getDataFileStreamer(InputFilename, &ErrorMessage);
@@ -73,13 +73,10 @@ int main(int argc, char **argv) {
DisplayFilename = "<stdin>";
else
DisplayFilename = InputFilename;
- M.reset(getStreamedBitcodeModule(DisplayFilename, Buffer.release(), Context,
- &ErrorMessage));
- if (M.get())
- if (std::error_code EC = M->materializeAllPermanently()) {
- ErrorMessage = EC.message();
- M.reset();
- }
+ ErrorOr<std::unique_ptr<Module>> MOrErr =
+ getStreamedBitcodeModule(DisplayFilename, Buffer.release(), Context);
+ M = std::move(*MOrErr);
+ M->materializeAllPermanently();
}
if (!M.get()) {
jvoung (off chromium) 2015/05/26 20:39:45 could be the else { } from if (streamer), since it
Derek Schuff 2015/05/26 22:01:33 Done.

Powered by Google App Engine
This is Rietveld 408576698