Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1151053003: my_activity.py: Fix to work with non-ascii characters (Closed)

Created:
5 years, 7 months ago by stevef
Modified:
5 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

my_activity.py: Fix to work with non-ascii characters The default encoding for python 2.7 strings is ascii. Some of the titles of issues, such as http://crbug.com/477941, contain non-ascii characters, and cause my_activity.py to throw an exception. Re-encode the unicode title string to ascii with the 'replace' option, to replace non-ascii characters with '?'. R=maruel@chromium.org BUG=none TEST=Run `my_activity.py` with #477941 in my issues list; correctly lists issues without throwing an exception. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295425

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M my_activity.py View 1 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
stevef
5 years, 7 months ago (2015-05-26 10:03:53 UTC) #1
M-A Ruel
https://codereview.chromium.org/1151053003/diff/1/my_activity.py File my_activity.py (right): https://codereview.chromium.org/1151053003/diff/1/my_activity.py#newcode863 my_activity.py:863: if __name__ == '__main__': Please have it use fix_encoding ...
5 years, 7 months ago (2015-05-26 14:02:45 UTC) #2
stevef
On 2015/05/26 14:02:45, M-A Ruel wrote: > https://codereview.chromium.org/1151053003/diff/1/my_activity.py > File my_activity.py (right): > > https://codereview.chromium.org/1151053003/diff/1/my_activity.py#newcode863 ...
5 years, 7 months ago (2015-05-26 21:13:43 UTC) #3
M-A Ruel
lgtm
5 years, 7 months ago (2015-05-27 12:50:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151053003/20001
5 years, 7 months ago (2015-05-27 12:50:06 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 12:52:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295425

Powered by Google App Engine
This is Rietveld 408576698