Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: base/android/jni_generator/testInnerClassNativesMultiple.golden

Issue 115103002: Android: sync up latest JNI generator changes from downstream. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adds extra params Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/jni_generator/testInnerClassNativesMultiple.golden
diff --git a/base/android/jni_generator/testInnerClassNativesMultiple.golden b/base/android/jni_generator/testInnerClassNativesMultiple.golden
index 81c97e9c97571ff623ce7324e3d0b2ff6ed79694..1341c89060899e93814e7632e5b7435c54075c55 100644
--- a/base/android/jni_generator/testInnerClassNativesMultiple.golden
+++ b/base/android/jni_generator/testInnerClassNativesMultiple.golden
@@ -1,4 +1,4 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -12,12 +12,7 @@
#include <jni.h>
-#include "base/android/jni_android.h"
-#include "base/android/scoped_java_ref.h"
-#include "base/basictypes.h"
-#include "base/logging.h"
-
-using base::android::ScopedJavaLocalRef;
+#include "base/android/jni_generator/jni_generator_helper.h"
// Step 1: forward declarations.
namespace {
@@ -27,48 +22,53 @@ const char kTestJniClassPath[] = "org/chromium/TestJni";
const char kMyInnerClassClassPath[] = "org/chromium/TestJni$MyInnerClass";
// Leaking this jclass as we cannot use LazyInstance from some threads.
jclass g_TestJni_clazz = NULL;
+
} // namespace
-static jint Init(JNIEnv* env, jobject obj);
+static jint Init(JNIEnv* env, jobject jcaller);
-static jint Init(JNIEnv* env, jobject obj);
+static jint Init(JNIEnv* env, jobject jcaller);
// Step 2: method stubs.
// Step 3: RegisterNatives.
-static bool RegisterNativesImpl(JNIEnv* env) {
+static const JNINativeMethod kMethodsMyOtherInnerClass[] = {
+ { "nativeInit",
+"("
+")"
+"I", reinterpret_cast<void*>(Init) },
+};
- g_TestJni_clazz = reinterpret_cast<jclass>(env->NewGlobalRef(
- base::android::GetClass(env, kTestJniClassPath).obj()));
- static const JNINativeMethod kMethodsMyOtherInnerClass[] = {
+static const JNINativeMethod kMethodsMyInnerClass[] = {
{ "nativeInit",
"("
")"
"I", reinterpret_cast<void*>(Init) },
- };
+};
+
+static bool RegisterNativesImpl(JNIEnv* env) {
+ g_TestJni_clazz = reinterpret_cast<jclass>(env->NewGlobalRef(
+ base::android::GetClass(env, kTestJniClassPath).obj()));
+
const int kMethodsMyOtherInnerClassSize =
arraysize(kMethodsMyOtherInnerClass);
if (env->RegisterNatives(g_MyOtherInnerClass_clazz,
kMethodsMyOtherInnerClass,
kMethodsMyOtherInnerClassSize) < 0) {
- LOG(ERROR) << "RegisterNatives failed in " << __FILE__;
+ jni_generator::HandleRegistrationError(
+ env, g_MyOtherInnerClass_clazz, __FILE__);
return false;
}
- static const JNINativeMethod kMethodsMyInnerClass[] = {
- { "nativeInit",
-"("
-")"
-"I", reinterpret_cast<void*>(Init) },
- };
const int kMethodsMyInnerClassSize = arraysize(kMethodsMyInnerClass);
if (env->RegisterNatives(g_MyInnerClass_clazz,
kMethodsMyInnerClass,
kMethodsMyInnerClassSize) < 0) {
- LOG(ERROR) << "RegisterNatives failed in " << __FILE__;
+ jni_generator::HandleRegistrationError(
+ env, g_MyInnerClass_clazz, __FILE__);
return false;
}

Powered by Google App Engine
This is Rietveld 408576698