tools/dom/templates/html/impl/impl_ScriptProcessorNode.darttemplate - Issue 11510013: Making ScriptProcessorNode not an EventTarget.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/dom/templates/html/impl/impl_ScriptProcessorNode.darttemplate

Issue 11510013: Making ScriptProcessorNode not an EventTarget. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 part of $LIBRARY;

	6

	7 $(ANNOTATIONS)class $CLASSNAME$EXTENDS$NATIVESPEC {

	8 void set onAudioProcess(EventListener listener) {
	blois 2013/03/13 00:46:49 should probably be void callback(AudioProcessingEv should probably be void callback(AudioProcessingEvent) rather than EventListener. podivilov 2013/03/13 07:57:56 AFAIR we deliberately abandoned attribute event li AFAIR we deliberately abandoned attribute event listeners in dart:html. Can't we implement on.audioProcess.add/remove stuff on top of JS onaudioprocess setter for consistency with other dart:html API? Emily Fortuna 2013/03/13 23:35:21 The reason this can't fit in like all the other ev Show quoted text On 2013/03/13 07:57:56, podivilov wrote: > AFAIR we deliberately abandoned attribute event listeners in dart:html. > Can't we implement on.audioProcess.add/remove stuff on top of JS onaudioprocess > setter for consistency with other dart:html API? The reason this can't fit in like all the other event handlers is because ScriptProcessorNode is not an EventTarget, and we were trying to avoid reinventing the wheel of Stream providers for this special case where there can only be one listener. In the newest CL I went ahead and did this though.
	9 $if DART2JS

	10 JS('void', '#.onaudioprocess = #', this,

	11 convertDartClosureToJS(listener, 1));

	12 $else

	13 //TODO(antonm): Get this working on Dartium.

	14 $endif

	15 }

	16 $!MEMBERS
	podivilov 2013/03/13 07:57:56 There's no onAudioProcess getter, right? Is it int There's no onAudioProcess getter, right? Is it intentional?
	17 }

	18

OLD	NEW

« tests/html/html.status ('K') | « tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate ('k') | no next file » | no next file with comments »