Chromium Code Reviews| Index: ppapi/host/resource_message_handler.cc |
| diff --git a/ppapi/host/resource_message_handler.cc b/ppapi/host/resource_message_handler.cc |
| index 9442c1564a21022b29feff22e961bc4aecb7f94d..41a8364713c9d7dded4669264bcabf30bfa7e77c 100644 |
| --- a/ppapi/host/resource_message_handler.cc |
| +++ b/ppapi/host/resource_message_handler.cc |
| @@ -22,6 +22,9 @@ void ResourceMessageHandler::RunMessageHandlerAndReply( |
| const IPC::Message& msg, |
| HostMessageContext* context) { |
| ReplyMessageContext reply_context = context->MakeReplyMessageContext(); |
| + // CAUTION: Handling the message may cause the destruction of this object. If |
| + // PP_OK_COMPLETIONPENDING is returned, we should assume that we might have |
|
yzshen1
2012/12/14 19:13:14
Why PP_OK_COMPLETIONPENDING is the only possible o
raymes
2012/12/17 04:07:57
Right now I'm making the assumption that if the me
yzshen1
2012/12/17 05:02:23
This assumption doesn't look very intuitive. Can i
raymes
2012/12/17 05:11:00
I tried to make it clear in the comment above but
yzshen1
2012/12/17 05:19:37
If my understanding is correct, it is not that it
|
| + // been destroyed after this. |
| reply_context.params.set_result(OnResourceMessageReceived(msg, context)); |
| // Sanity check the resource handler. Note if the result was |