Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1150953003: Remove IME API interface usage from Chromium (Closed)

Created:
5 years, 6 months ago by kochi
Modified:
5 years, 6 months ago
Reviewers:
tkent, Avi (use Gerrit)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove IME API interface usage from Chromium This is a start of 3-side patch to remove interface in Blink to get notification about IME candidate window change events. More code cleanups on Chromium side will follow once the interface is removed from Blink's WebWidgets.h. Blink side change is https://codereview.chromium.org/1162853002/ BUG=494856 Committed: https://crrev.com/6ec94146260f880f23ff68013468e2aced644089 Cr-Commit-Position: refs/heads/master@{#332277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M content/renderer/render_view_browsertest.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150953003/1
5 years, 6 months ago (2015-06-01 05:40:01 UTC) #2
kochi
tkent-san Could you take a look?
5 years, 6 months ago (2015-06-01 06:52:29 UTC) #4
tkent
lgtm by non-owner
5 years, 6 months ago (2015-06-01 07:02:30 UTC) #5
kochi
avi, could you review for content/ onwer?
5 years, 6 months ago (2015-06-01 07:09:54 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-01 07:27:05 UTC) #9
Avi (use Gerrit)
LGTM
5 years, 6 months ago (2015-06-01 15:04:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150953003/1
5 years, 6 months ago (2015-06-01 23:34:40 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-02 00:49:02 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 00:50:51 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ec94146260f880f23ff68013468e2aced644089
Cr-Commit-Position: refs/heads/master@{#332277}

Powered by Google App Engine
This is Rietveld 408576698