Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1150943002: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in net/base (Closed)

Created:
5 years, 7 months ago by HariS
Modified:
5 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in net/base BUG=457697 Committed: https://crrev.com/6f7c6873050f8021d0667cd9c7bec47471202d98 Cr-Commit-Position: refs/heads/master@{#331540}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated AUTHERS file with respect of comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/base/elements_upload_data_stream.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
HariS
Please review the changes.
5 years, 7 months ago (2015-05-21 09:11:33 UTC) #2
mmenke
Doesn't look like you've signed the individual contributors agreement: https://cla.developers.google.com/about/google-individual?csw=1 https://codereview.chromium.org/1150943002/diff/1/AUTHORS File AUTHORS (right): https://codereview.chromium.org/1150943002/diff/1/AUTHORS#newcode596 ...
5 years, 7 months ago (2015-05-21 15:20:05 UTC) #3
HariS
Made suggested change in AUTHORS files. CLA sign in also done. Please review the code ...
5 years, 7 months ago (2015-05-25 04:14:51 UTC) #4
mmenke
LGTM
5 years, 6 months ago (2015-05-26 14:02:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150943002/20001
5 years, 6 months ago (2015-05-27 04:30:05 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-05-27 06:15:08 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-05-27 06:16:12 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f7c6873050f8021d0667cd9c7bec47471202d98
Cr-Commit-Position: refs/heads/master@{#331540}

Powered by Google App Engine
This is Rietveld 408576698