Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1150923005: [turbofan] --turbo should not imply --turbo-type-feedback. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] --turbo should not imply --turbo-type-feedback. The --turbo flag should reflect our TurboFan staging configuration, and for now that does not include the JSTypeFeedbackSpecializer. R=mstarzinger@chromium.org Committed: https://crrev.com/f2ffa6ade5e28d6ff1ed8895e320fc77bfb08c68 Cr-Commit-Position: refs/heads/master@{#28535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-21 09:33:57 UTC) #1
Benedikt Meurer
Hey Michi, As discussed a few minutes ago. Please take a look. Thanks, Benedikt
5 years, 7 months ago (2015-05-21 09:34:20 UTC) #2
Michael Starzinger
LGTM, if Ben agrees.
5 years, 7 months ago (2015-05-21 09:35:05 UTC) #3
Benedikt Meurer
On 2015/05/21 09:35:05, Michael Starzinger wrote: > LGTM, if Ben agrees. Yeah had a talk ...
5 years, 7 months ago (2015-05-21 09:41:53 UTC) #4
Benedikt Meurer
Committed patchset #1 (id:1) manually as f2ffa6ade5e28d6ff1ed8895e320fc77bfb08c68 (presubmit successful).
5 years, 7 months ago (2015-05-21 09:42:31 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 09:42:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2ffa6ade5e28d6ff1ed8895e320fc77bfb08c68
Cr-Commit-Position: refs/heads/master@{#28535}

Powered by Google App Engine
This is Rietveld 408576698