Issue 1150903004: Set up binary artifact downloading hook

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1150903004: Set up binary artifact downloading hook (Closed)

Created:
5 years, 7 months ago by jamesr

Modified:
5 years, 7 months ago

Reviewers:
viettrungluu

CC:
mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/monet.git@master

Target Ref:
refs/heads/master

Project:
monet

Visibility:
Public.

Set up binary artifact downloading hook This teaches gclient runhooks to download the mojo_shell and dart blob binaries from google storage. R=viettrungluu@chromium.org Committed: https://github.com/domokit/monet01dfd4219e6cb5a9e84bcb9e24a2e2a07d1b45c1

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -2 lines)			Patch
M	DEPS	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	build/module_args/mojo.gni	View	1 chunk	+0 lines, -2 lines	0 comments	Download
A	third_party/mojo/MOJO_VERSION	View	1 chunk	+1 line, -0 lines	1 comment	Download
A	tools/find_depot_tools.py	View	1 chunk	+45 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

viettrungluu

LGTM. Request for the future: Maybe put [monet] in the "subject" to make it more ...

5 years, 7 months ago (2015-05-22 18:22:04 UTC) #3

jamesr

On 2015/05/22 18:22:04, viettrungluu wrote: > LGTM. > > Request for the future: Maybe put ...

5 years, 7 months ago (2015-05-22 19:43:45 UTC) #4

jamesr

5 years, 7 months ago (2015-05-22 19:43:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
01dfd4219e6cb5a9e84bcb9e24a2e2a07d1b45c1 (presubmit successful).