Source/bindings/scripts/v8_methods.py - Issue 1150863004: toImplArguments should return HeapVector for Union types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 1150863004: toImplArguments should return HeapVector for Union types. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index 5831603c1503011358bb44e4bf6c6bf4e72db6a5..eab6a0460c266ecb0790d3251b3ba734c79f2956 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -371,8 +371,13 @@ def v8_value_to_local_cpp_variadic_value(method, argument, index, return_promise

else:

check_expression = 'exceptionState.throwIfNeeded()'

+ if idl_type.is_dictionary or idl_type.is_union_type:

haraken 2015/05/27 11:45:05 bashi-san: Would it make more sense to set idl_typ

bashi 2015/05/28 01:36:49 either is fine for me.

+ vector_type = 'HeapVector'

+ else:

+ vector_type = 'Vector'

return {

- 'assign_expression': 'toImplArguments<%s>(info, %s, exceptionState)' % (this_cpp_type, index),

+ 'assign_expression': 'toImplArguments<%s<%s>>(info, %s, exceptionState)' % (vector_type, this_cpp_type, index),

'check_expression': check_expression,

'cpp_type': this_cpp_type,

'cpp_name': argument.name,

« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »