toImplArguments should return HeapVector for Union types.

toImplArguments should return HeapVector for Union types.

In https://codereview.chromium.org/1118993002, We are using
HeapVector for Union types. So, for arguments of type array 
of Union, toImplArguments should return HeapVector of that
Union types.

BUG=475801
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196039

[Paritosh Kumar, 2015-05-27 10:27:08]

The CQ bit was checked by paritosh.in@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-05-27 10:27:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1150863004/1

[Paritosh Kumar, 2015-05-27 11:15:35]

The CQ bit was unchecked by paritosh.in@samsung.com

[Paritosh Kumar, 2015-05-27 11:30:15]

paritosh.in@samsung.com changed reviewers:
+ haraken@chromium.org, philipj@opera.com, tkent@chromium.org

[Paritosh Kumar, 2015-05-27 11:32:11]

Please have a look.

[haraken, 2015-05-27 11:45:05]

haraken@chromium.org changed reviewers:
+ bashi@chromium.org

[haraken, 2015-05-27 11:45:05]

LGTM

https://codereview.chromium.org/1150863004/diff/1/Source/bindings/scripts/v8_...
File Source/bindings/scripts/v8_methods.py (right):

https://codereview.chromium.org/1150863004/diff/1/Source/bindings/scripts/v8_...
Source/bindings/scripts/v8_methods.py:374: if idl_type.is_dictionary or
idl_type.is_union_type:

bashi-san: Would it make more sense to set idl_type.is_garbage_collected for IDL
dictionaries and union types and use it here?

[bashi, 2015-05-28 01:36:49]

LGTM with nit.

Could you add a testcase for HeapVector in bindings-tests?

https://codereview.chromium.org/1150863004/diff/1/Source/bindings/scripts/v8_...
File Source/bindings/scripts/v8_methods.py (right):

https://codereview.chromium.org/1150863004/diff/1/Source/bindings/scripts/v8_...
Source/bindings/scripts/v8_methods.py:374: if idl_type.is_dictionary or
idl_type.is_union_type:
On 2015/05/27 11:45:05, haraken wrote:
> 
> bashi-san: Would it make more sense to set idl_type.is_garbage_collected for
IDL
> dictionaries and union types and use it here?
> 

either is fine for me.

[Paritosh Kumar, 2015-05-28 05:40:22]

On 2015/05/28 01:36:49, bashi1 wrote:
> LGTM with nit.
> 
> Could you add a testcase for HeapVector in bindings-tests?
> 
>
https://codereview.chromium.org/1150863004/diff/1/Source/bindings/scripts/v8_...
> File Source/bindings/scripts/v8_methods.py (right):
> 
>
https://codereview.chromium.org/1150863004/diff/1/Source/bindings/scripts/v8_...
> Source/bindings/scripts/v8_methods.py:374: if idl_type.is_dictionary or
> idl_type.is_union_type:
> On 2015/05/27 11:45:05, haraken wrote:
> > 
> > bashi-san: Would it make more sense to set idl_type.is_garbage_collected for
> IDL
> > dictionaries and union types and use it here?
> > 
> 
> either is fine for me.

Thanks haraken and bashi
Added test for Array of Union Types, Please have a look.

[haraken, 2015-05-28 05:42:53]

Still LGTM

[Paritosh Kumar, 2015-05-28 05:45:04]

The CQ bit was checked by paritosh.in@samsung.com

[Paritosh Kumar, 2015-05-28 05:45:05]

The patchset sent to the CQ was uploaded after l-g-t-m from bashi@chromium.org
Link to the patchset: https://codereview.chromium.org/1150863004/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-05-28 05:45:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1150863004/20001

[commit-bot: I haz the power, 2015-05-28 05:52:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-28 05:52:32]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

[Paritosh Kumar, 2015-05-28 05:58:50]

The CQ bit was checked by paritosh.in@samsung.com to run a CQ dry run

[Paritosh Kumar, 2015-05-28 05:58:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, bashi@chromium.org
Link to the patchset: https://codereview.chromium.org/1150863004/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-05-28 05:59:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1150863004/40001

[commit-bot: I haz the power, 2015-05-28 07:32:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-28 07:32:05]

Dry run: This issue passed the CQ dry run.

[Paritosh Kumar, 2015-05-28 07:33:05]

The CQ bit was checked by paritosh.in@samsung.com

[commit-bot: I haz the power, 2015-05-28 07:33:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1150863004/40001

[commit-bot: I haz the power, 2015-05-28 07:36:45]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196039