Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Unified Diff: chrome/browser/chromeos/extensions/echo_private_api.cc

Issue 1150863002: Make DictionaryValue::DeepCopyWithoutEmptyChildren return a scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove semicolons Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/values_unittest.cc ('k') | chrome/browser/prefs/tracked/pref_hash_calculator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/echo_private_api.cc
diff --git a/chrome/browser/chromeos/extensions/echo_private_api.cc b/chrome/browser/chromeos/extensions/echo_private_api.cc
index 1aa9a89707eb1fe28605ba50ba701ab7d6b69f7c..7b74050fe8ba40511406ebc98a26f79a5329adb5 100644
--- a/chrome/browser/chromeos/extensions/echo_private_api.cc
+++ b/chrome/browser/chromeos/extensions/echo_private_api.cc
@@ -97,12 +97,12 @@ bool EchoPrivateSetOfferInfoFunction::RunSync() {
EXTENSION_FUNCTION_VALIDATE(params);
const std::string& service_id = params->id;
- base::DictionaryValue* dict = params->offer_info.
- additional_properties.DeepCopyWithoutEmptyChildren();
+ scoped_ptr<base::DictionaryValue> dict =
+ params->offer_info.additional_properties.DeepCopyWithoutEmptyChildren();
PrefService* local_state = g_browser_process->local_state();
DictionaryPrefUpdate offer_update(local_state, prefs::kEchoCheckedOffers);
- offer_update->SetWithoutPathExpansion("echo." + service_id, dict);
+ offer_update->SetWithoutPathExpansion("echo." + service_id, dict.Pass());
return true;
}
« no previous file with comments | « base/values_unittest.cc ('k') | chrome/browser/prefs/tracked/pref_hash_calculator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698