Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1150853009: [x64] Smi zero can be used as an immediate. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Smi zero can be used as an immediate. R=jarin@chromium.org Committed: https://crrev.com/a961d6c0146e3ee4bb8a4baa50ca475b56239bc5 Cr-Commit-Position: refs/heads/master@{#28786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/compiler/x64/code-generator-x64.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-03 10:57:07 UTC) #1
Jarin
lgtm
5 years, 6 months ago (2015-06-03 11:03:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150853009/1
5 years, 6 months ago (2015-06-03 11:05:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 11:23:10 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 11:23:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a961d6c0146e3ee4bb8a4baa50ca475b56239bc5
Cr-Commit-Position: refs/heads/master@{#28786}

Powered by Google App Engine
This is Rietveld 408576698