Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1150853004: [bindings] Use |PostMessage| attribute for CrossOriginServiceWorkerClient.postMessage to eliminate … (Closed)

Created:
5 years, 7 months ago by vivekg_samsung
Modified:
5 years, 6 months ago
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Use |PostMessage| attribute for CrossOriginServiceWorkerClient.postMessage to eliminate custom bindings The CL [1] has introduced |PostMessage| IDL extended attribute to auto-generate the code required for interfaces using |postMessage| method. In doing so, the bindings template generator uses |interface_name| while creating the ExceptionState object here [2]. In this case, |CrossOriginServiceWorkerClient| name will be used instead of |ServiceWorkerClient|. BUG=345519 [1] https://codereview.chromium.org/1159653002 [2] https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/bindings/core/v8/PostMessage.h&l=25 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
D Source/bindings/modules/v8/custom/V8CrossOriginServiceWorkerClientCustom.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M Source/bindings/modules/v8/custom/custom.gni View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/modules/v8/custom/custom.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/navigatorconnect/CrossOriginServiceWorkerClient.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
vivekg
PTAL, thanks.
5 years, 7 months ago (2015-05-26 04:08:14 UTC) #2
haraken
LGTM but let's wait for worker guy's approval.
5 years, 7 months ago (2015-05-26 04:10:52 UTC) #4
falken
lgtm but mek is the navigatorconnect OWNER
5 years, 7 months ago (2015-05-26 05:08:30 UTC) #6
Marijn Kruisselbrink
lgtm
5 years, 6 months ago (2015-05-26 17:08:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150853004/1
5 years, 6 months ago (2015-05-26 17:20:40 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-05-26 17:41:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195915

Powered by Google App Engine
This is Rietveld 408576698