Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1150853003: Add @VisibleForTesting to fix ChromePublic release build. (Closed)

Created:
5 years, 7 months ago by newt (away)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add @VisibleForTesting to fix ChromePublic release build. These two methods were being obfuscated or removed by proguard, which cause the release build to fail for chrome_public_test_apk. BUG=484934 R=pvalenzuela@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/2338a2e91cf971709acdfb1dedfa70274ab6d867

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java View 2 chunks +2 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
newt (away)
PTAL
5 years, 7 months ago (2015-05-21 01:09:08 UTC) #2
pval...(no longer on Chromium)
lgtm My apologies for creating this breakage. Thanks for the fix. https://codereview.chromium.org/1150853003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java File chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java (right): ...
5 years, 7 months ago (2015-05-21 01:13:55 UTC) #3
newt (away)
On 2015/05/21 01:13:55, pvalenzuela wrote: > lgtm > > My apologies for creating this breakage. ...
5 years, 7 months ago (2015-05-21 01:23:40 UTC) #4
pval...(no longer on Chromium)
On 2015/05/21 01:23:40, newt wrote: > On 2015/05/21 01:13:55, pvalenzuela wrote: > > lgtm > ...
5 years, 7 months ago (2015-05-21 01:26:16 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2338a2e91cf971709acdfb1dedfa70274ab6d867 Cr-Commit-Position: refs/heads/master@{#330869}
5 years, 7 months ago (2015-05-21 01:36:53 UTC) #6
newt (away)
5 years, 7 months ago (2015-05-21 01:37:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2338a2e91cf971709acdfb1dedfa70274ab6d867 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698