Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1150833003: Clean up Sk4f xfermodes and covered _SSE2 xfermodes. (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
f(malita), mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up Sk4f xfermodes and covered _SSE2 xfermodes. Before I get going on fixing Plus, it's nice to clear out the dead cruft. BUG=skia:3852 Committed: https://skia.googlesource.com/skia/+/5a7cd87bd27b9e9156a376882d66edb7aaa1903e

Patch Set 1 #

Patch Set 2 : Warning #

Patch Set 3 : tweak wording #

Patch Set 4 : dead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -556 lines) Patch
M src/core/SkXfermode.cpp View 1 2 6 chunks +57 lines, -261 lines 0 comments Download
M src/opts/SkXfermode_opts_SSE2.cpp View 1 2 3 5 chunks +12 lines, -295 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150833003/80001
5 years, 7 months ago (2015-05-21 15:25:16 UTC) #3
mtklein_C
5 years, 7 months ago (2015-05-21 15:30:58 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-21 15:31:32 UTC) #7
reed1
lgtm
5 years, 7 months ago (2015-05-21 21:05:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150833003/80001
5 years, 7 months ago (2015-05-21 21:06:34 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 21:08:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://skia.googlesource.com/skia/+/5a7cd87bd27b9e9156a376882d66edb7aaa1903e

Powered by Google App Engine
This is Rietveld 408576698