Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: content/browser/frame_host/render_frame_host_manager_browsertest.cc

Issue 1150793002: Add ref-count on RenderViewHost for each new RenderFrameProxyHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes and missed CHECK. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager_browsertest.cc
diff --git a/content/browser/frame_host/render_frame_host_manager_browsertest.cc b/content/browser/frame_host/render_frame_host_manager_browsertest.cc
index 9de16f8e9c0be905594f840c66bddc33e4f83358..9dfbc414a196895ba63b991eea50041515ed6e0d 100644
--- a/content/browser/frame_host/render_frame_host_manager_browsertest.cc
+++ b/content/browser/frame_host/render_frame_host_manager_browsertest.cc
@@ -35,6 +35,7 @@
#include "content/shell/browser/shell.h"
#include "net/base/net_util.h"
#include "net/dns/mock_host_resolver.h"
+#include "net/test/embedded_test_server/embedded_test_server.h"
#include "net/test/spawned_test_server/spawned_test_server.h"
using base::ASCIIToUTF16;
@@ -87,6 +88,13 @@ class RenderFrameHostManagerTest : public ContentBrowserTest {
foo_host_port_.set_host(foo_com_);
}
+ void StartEmbeddedServer() {
+ // Support multiple sites on the embedded test server.
+ host_resolver()->AddRule("*", "127.0.0.1");
+ ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
+ SetupCrossSiteRedirector(embedded_test_server());
+ }
+
// Returns a URL on foo.com with the given path.
GURL GetCrossSiteURL(const std::string& path) {
GURL cross_site_url(test_server()->GetURL(path));
@@ -1722,4 +1730,34 @@ IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest,
shell()->web_contents()->GetRenderProcessHost()->GetID(), file));
}
+// Ensures that no RenderFrameHost/RenderViewHost objects are leaked when
+// doing a simple cross-process navigation.
+IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest,
+ CleanupOnCrossProcessNavigation) {
+ StartEmbeddedServer();
+
+ // Do an initial navigation and capture objects we expect to be cleaned up
+ // on cross-process navigation.
+ GURL start_url = embedded_test_server()->GetURL("/title1.html");
+ NavigateToURL(shell(), start_url);
+
+ FrameTreeNode* root = static_cast<WebContentsImpl*>(shell()->web_contents())
+ ->GetFrameTree()
+ ->root();
+ SiteInstance* orig_site = root->current_frame_host()->GetSiteInstance();
+ int initial_process_id = orig_site->GetProcess()->GetID();
+ int initial_rfh_id = root->current_frame_host()->GetRoutingID();
+ int initial_rvh_id =
+ root->current_frame_host()->render_view_host()->GetRoutingID();
+
+ // Navigate cross-process and ensure that cleanup is performed as expected.
+ GURL cross_site_url =
+ embedded_test_server()->GetURL("foo.com", "/title2.html");
+ NavigateToURL(shell(), cross_site_url);
+
+ EXPECT_NE(orig_site, root->current_frame_host()->GetSiteInstance());
+ EXPECT_FALSE(RenderFrameHost::FromID(initial_process_id, initial_rfh_id));
+ EXPECT_FALSE(RenderViewHost::FromID(initial_process_id, initial_rvh_id));
+}
+
} // namespace content
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/frame_host/render_frame_proxy_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698