src/compiler/js-generic-lowering.cc - Issue 1150723005: [turbofan] Optimized lowering of DYNAMIC_GLOBAL lookup slot loads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-generic-lowering.cc

Issue 1150723005: [turbofan] Optimized lowering of DYNAMIC_GLOBAL lookup slot loads. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebased. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/js-generic-lowering.cc

diff --git a/src/compiler/js-generic-lowering.cc b/src/compiler/js-generic-lowering.cc

index 876a4563591cf7999a8aead27b3610d31123a8be..3fc0496450e5ee9550d0dbc54d7fef9fc2759a84 100644

--- a/src/compiler/js-generic-lowering.cc

+++ b/src/compiler/js-generic-lowering.cc

@@ -454,6 +454,7 @@ void JSGenericLowering::LowerJSLoadDynamicGlobal(Node* node) {

: Runtime::kLoadLookupSlotNoReferenceError;

Node* projection = graph()->NewNode(common()->Projection(0), node);

NodeProperties::ReplaceWithValue(node, projection, node, node);

+ node->RemoveInput(NodeProperties::FirstFrameStateIndex(node) + 1);

node->InsertInput(zone(), 1, jsgraph()->Constant(access.name()));

ReplaceWithRuntimeCall(node, function_id);

projection->ReplaceInput(0, node);

« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/compiler/js-operator.h » ('j') | no next file with comments »