Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 11507017: Add PluginServiceStub for builds with enable_plugins==0 (Closed)

Created:
8 years ago by nilesh
Modified:
8 years ago
Reviewers:
brettw, sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add PluginServiceStub for builds with enable_plugins==0 BUG=162667

Patch Set 1 #

Patch Set 2 : Fixed unittests for Android. #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -7 lines) Patch
M build/android/gtest_filter/unit_tests_disabled View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/loader/buffered_resource_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A content/browser/plugin_service_stub.h View 1 2 3 1 chunk +78 lines, -0 lines 0 comments Download
A content/browser/plugin_service_stub.cc View 1 chunk +78 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nilesh
Hi Sky/Brett, Please take a look. Using PluginService interface in both chrome and content makes ...
8 years ago (2012-12-11 17:42:35 UTC) #1
jam
As discussed before, we don't want to have stub objects for android builds. This creates ...
8 years ago (2012-12-11 17:45:50 UTC) #2
nilesh
8 years ago (2012-12-15 01:12:24 UTC) #3
On 2012/12/11 17:45:50, John Abd-El-Malek wrote:
> As discussed before, we don't want to have stub objects for android builds.
This
> creates more work for developers when new methods are added (i.e. to remember
to
> update the stubs). More importantly though, the interface now is the public
API.
> The internal implementation (PluginServiceImpl) is what content internally
> calls. Now it can always cast to that interface. If you add another
> implementation, then casting won't work. This means that internal methods
would
> have to be put on the public interface, which is not good.

Hi John, 
Thanks for your comments. I am trying a different approach which does not get
rid of the PluginServiceImpl. Please take a look:
https://codereview.chromium.org/11577031/

Powered by Google App Engine
This is Rietveld 408576698