Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: extensions/common/permissions/permissions_data.h

Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/extension_messages.h ('k') | extensions/common/permissions/permissions_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/permissions/permissions_data.h
diff --git a/extensions/common/permissions/permissions_data.h b/extensions/common/permissions/permissions_data.h
index 6a84566dc1cc5de553ea34dc1eb7c59ca72a5603..30857d3e7dabed4d0fe7609b0fd5a399dc53a439 100644
--- a/extensions/common/permissions/permissions_data.h
+++ b/extensions/common/permissions/permissions_data.h
@@ -49,7 +49,6 @@ class PermissionsData {
// Otherwise, default policy should decide.
virtual bool CanExecuteScriptOnPage(const Extension* extension,
const GURL& document_url,
- const GURL& top_document_url,
int tab_id,
int process_id,
std::string* error) = 0;
@@ -80,7 +79,6 @@ class PermissionsData {
// as is commonly the case for chrome:// urls.
// NOTE: You probably want to use CanAccessPage().
static bool IsRestrictedUrl(const GURL& document_url,
- const GURL& top_frame_url,
const Extension* extension,
std::string* error);
@@ -158,7 +156,6 @@ class PermissionsData {
// with the reason the extension cannot access the page.
bool CanAccessPage(const Extension* extension,
const GURL& document_url,
- const GURL& top_document_url,
int tab_id,
int process_id,
std::string* error) const;
@@ -167,7 +164,6 @@ class PermissionsData {
// know how to wait for permission.
AccessType GetPageAccess(const Extension* extension,
const GURL& document_url,
- const GURL& top_document_url,
int tab_id,
int process_id,
std::string* error) const;
@@ -180,7 +176,6 @@ class PermissionsData {
// method.
bool CanRunContentScriptOnPage(const Extension* extension,
const GURL& document_url,
- const GURL& top_document_url,
int tab_id,
int process_id,
std::string* error) const;
@@ -190,7 +185,6 @@ class PermissionsData {
// know how to wait for permission.
AccessType GetContentScriptAccess(const Extension* extension,
const GURL& document_url,
- const GURL& top_document_url,
int tab_id,
int process_id,
std::string* error) const;
@@ -241,7 +235,6 @@ class PermissionsData {
// sites (like the webstore or chrome:// urls).
AccessType CanRunOnPage(const Extension* extension,
const GURL& document_url,
- const GURL& top_document_url,
int tab_id,
int process_id,
const URLPatternSet& permitted_url_patterns,
« no previous file with comments | « extensions/common/extension_messages.h ('k') | extensions/common/permissions/permissions_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698