chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc - Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc

Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/extensions/renderer_permissions_policy_delegate.cc ('k') | extensions/browser/extension_web_contents_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc

diff --git a/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc b/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc

index 1889b87e918505366b04ada870cfc5055e1413d5..8c4ba09dc26e18196a89fd6704e9f5e636898e5f 100644

--- a/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc

+++ b/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc

@@ -67,8 +67,7 @@ TEST_F(RendererPermissionsPolicyDelegateTest, CannotScriptWebstore) {

std::string error;

EXPECT_TRUE(extension->permissions_data()->CanAccessPage(

- extension.get(), kAnyUrl, kAnyUrl, -1, -1, &error))

- << error;

+ extension.get(), kAnyUrl, -1, -1, &error)) << error;

// Pretend we are in the webstore process. We should not be able to execute

// script.

@@ -77,7 +76,7 @@ TEST_F(RendererPermissionsPolicyDelegateTest, CannotScriptWebstore) {

extension_dispatcher_->OnLoadedInternal(webstore_extension);

extension_dispatcher_->OnActivateExtension(extensions::kWebStoreAppId);

EXPECT_FALSE(extension->permissions_data()->CanAccessPage(

- extension.get(), kAnyUrl, kAnyUrl, -1, -1, &error))

+ extension.get(), kAnyUrl, -1, -1, &error))

<< error;

}