chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/debugger/debugger_api.cc ('k') | chrome/browser/extensions/browser_permissions_policy_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index 0e762ea5d1bdbed7f0082942d1f4f6c4cf46f302..72795ac087f40441e959bdbd182c6e2584534144 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -1275,7 +1275,6 @@ bool TabsUpdateFunction::UpdateURL(const std::string &url_string,

if (!extension()->permissions_data()->CanAccessPage(

extension(),

web_contents_->GetURL(),

- web_contents_->GetURL(),

tab_id,

process ? process->GetID() : -1,

&error_)) {

@@ -1799,7 +1798,6 @@ bool ExecuteCodeInTabFunction::CanExecuteScriptOnPage() {

if (!extension()->permissions_data()->CanAccessPage(

extension(),

contents->GetURL(),

- contents->GetURL(),

execute_tab_id_,

process ? process->GetID() : -1,

&error_)) {

@@ -1887,7 +1885,7 @@ bool TabsSetZoomFunction::RunAsync() {

return false;

GURL url(web_contents->GetVisibleURL());

- if (PermissionsData::IsRestrictedUrl(url, url, extension(), &error_))

+ if (PermissionsData::IsRestrictedUrl(url, extension(), &error_))

return false;

ZoomController* zoom_controller =

@@ -1939,7 +1937,7 @@ bool TabsSetZoomSettingsFunction::RunAsync() {

return false;

GURL url(web_contents->GetVisibleURL());

- if (PermissionsData::IsRestrictedUrl(url, url, extension(), &error_))

+ if (PermissionsData::IsRestrictedUrl(url, extension(), &error_))

return false;

// "per-origin" scope is only available in "automatic" mode.