chrome/browser/extensions/api/debugger/debugger_api.cc - Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api.cc

Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/automation_internal/automation_internal_api.cc ('k') | chrome/browser/extensions/api/tabs/tabs_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/debugger/debugger_api.cc

diff --git a/chrome/browser/extensions/api/debugger/debugger_api.cc b/chrome/browser/extensions/api/debugger/debugger_api.cc

index e00cd84c05dd4a0ef6565142abbfcb9ba2be2ded..9dbe9b359e43c5dcbf4f3a511be51167f360d0b8 100644

--- a/chrome/browser/extensions/api/debugger/debugger_api.cc

+++ b/chrome/browser/extensions/api/debugger/debugger_api.cc

@@ -508,7 +508,7 @@ bool DebuggerFunction::InitAgentHost() {

if (result && web_contents) {

// TODO(rdevlin.cronin) This should definitely be GetLastCommittedURL().

GURL url = web_contents->GetVisibleURL();

- if (PermissionsData::IsRestrictedUrl(url, url, extension(), &error_))

+ if (PermissionsData::IsRestrictedUrl(url, extension(), &error_))

return false;

agent_host_ = DevToolsAgentHost::GetOrCreateFor(web_contents);

}

@@ -518,7 +518,6 @@ bool DebuggerFunction::InitAgentHost() {

->GetBackgroundHostForExtension(*debuggee_.extension_id);

if (extension_host) {

if (PermissionsData::IsRestrictedUrl(extension_host->GetURL(),

- extension_host->GetURL(),

extension(),

&error_)) {

return false;

@@ -530,7 +529,6 @@ bool DebuggerFunction::InitAgentHost() {

agent_host_ = DevToolsAgentHost::GetForId(*debuggee_.target_id);

if (agent_host_.get()) {

if (PermissionsData::IsRestrictedUrl(agent_host_->GetURL(),

- agent_host_->GetURL(),

extension(),

&error_)) {

agent_host_ = nullptr;