chrome/browser/extensions/api/automation_internal/automation_internal_api.cc - Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

diff --git a/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc b/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

index f4d2092a7445cbed0ea58fa26113ab52401878cd..353faf90e5668f62fa7cca703e8f723182859976 100644

--- a/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

+++ b/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

@@ -144,7 +144,7 @@ bool CanRequestAutomation(const Extension* extension,

int process_id = process ? process->GetID() : -1;

std::string unused_error;

return extension->permissions_data()->CanAccessPage(

- extension, url, url, tab_id, process_id, &unused_error);

+ extension, url, tab_id, process_id, &unused_error);

}

// Helper class that implements an action adapter for a |RenderFrameHost|.

« no previous file with comments | « chrome/browser/extensions/active_tab_unittest.cc ('k') | chrome/browser/extensions/api/debugger/debugger_api.cc » ('j') | no next file with comments »