chrome/browser/extensions/active_tab_unittest.cc - Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/active_tab_unittest.cc

Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/active_script_controller.cc ('k') | chrome/browser/extensions/api/automation_internal/automation_internal_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/active_tab_unittest.cc

diff --git a/chrome/browser/extensions/active_tab_unittest.cc b/chrome/browser/extensions/active_tab_unittest.cc

index d86665aae0771eb5c52918d4a8a1620bd7e55ccd..3a678df4a497837f30c4d8beaed0579201f8115e 100644

--- a/chrome/browser/extensions/active_tab_unittest.cc

+++ b/chrome/browser/extensions/active_tab_unittest.cc

@@ -108,7 +108,7 @@ class ActiveTabTest : public ChromeRenderViewHostTestHarness {

int tab_id) {

const PermissionsData* permissions_data = extension->permissions_data();

bool script = permissions_data->CanAccessPage(

- extension.get(), url, url, tab_id, -1, NULL);

+ extension.get(), url, tab_id, -1, NULL);

bool capture = HasTabsPermission(extension, tab_id) &&

permissions_data->CanCaptureVisiblePage(tab_id, NULL);

switch (feature) {

@@ -276,7 +276,7 @@ TEST_F(ActiveTabTest, GrantToSinglePage) {

EXPECT_TRUE(IsAllowed(extension, chromium, PERMITTED_CAPTURE_ONLY));

EXPECT_TRUE(IsAllowed(another_extension, chromium, PERMITTED_CAPTURE_ONLY));

EXPECT_TRUE(IsBlocked(extension_without_active_tab, chromium));

-};

TEST_F(ActiveTabTest, Uninstalling) {

// Some semi-arbitrary setup.