Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1150683004: ARM64: do not optimize away shift if its result is used as both left and right (Closed)

Created:
5 years, 7 months ago by ulan
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ARM64: do not optimize away shift if its result is used as both left and right arguments. BUG=chromium:491049 LOG=NO TEST=mjsunit/regress/regress-491049.js

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/arm64/lithium-arm64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-491049.js View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ulan
PTAL
5 years, 7 months ago (2015-05-27 15:54:01 UTC) #2
Benedikt Meurer
lgtm
5 years, 7 months ago (2015-05-27 17:22:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150683004/1
5 years, 7 months ago (2015-05-27 17:22:30 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 17:33:52 UTC) #7
Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

Powered by Google App Engine
This is Rietveld 408576698