Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1150673002: Add a TurboFan skeleton for StringAddStub. (Closed)

Created:
5 years, 7 months ago by Sven Panne
Modified:
5 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a TurboFan skeleton for StringAddStub. Currently the stub simply calls out to the runtime, this will be improved in a later CLs. The current state at least avoids bit-rot and later merging horror. Fixes frame construction logic for stubs, too, and contains quite a few tiny cleanups in stub-land. Committed: https://crrev.com/f91503f25587cf7fdd57edc460fb2349f9ea9c2c Cr-Commit-Position: refs/heads/master@{#28555}

Patch Set 1 #

Patch Set 2 : Make GCC happy #

Patch Set 3 : Fixed frame construction logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -69 lines) Patch
M src/code-stubs.h View 10 chunks +66 lines, -42 lines 0 comments Download
M src/code-stubs.cc View 1 1 chunk +22 lines, -11 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/code-generator.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/instruction.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/globals.h View 1 2 chunks +12 lines, -1 line 0 comments Download
M src/runtime.js View 1 2 chunks +5 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-stubs.cc View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sven Panne
5 years, 7 months ago (2015-05-20 15:19:44 UTC) #2
mvstanton
Hi Sven, LGTM.
5 years, 7 months ago (2015-05-21 08:57:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150673002/40001
5 years, 7 months ago (2015-05-21 14:06:14 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-21 14:31:49 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 14:32:09 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f91503f25587cf7fdd57edc460fb2349f9ea9c2c
Cr-Commit-Position: refs/heads/master@{#28555}

Powered by Google App Engine
This is Rietveld 408576698