Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1150663003: Remove --enable-region-based-columns command line flag. (Closed)

Created:
5 years, 7 months ago by mstensho (USE GERRIT)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove --enable-region-based-columns command line flag. Region based columns (aka. the new multicol implementation) now gets enabled via an entry in RunTimeEnabledFeatures in Blink. BUG=350853 R=jochen@chromium.org,mkwst@chromium.org Committed: https://crrev.com/cf3c13e6562ee31f777944bae2461bac87d6ca9f Cr-Commit-Position: refs/heads/master@{#331767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
mstensho (USE GERRIT)
5 years, 7 months ago (2015-05-26 20:51:59 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-27 14:58:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150663003/1
5 years, 7 months ago (2015-05-27 15:37:30 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/66196)
5 years, 7 months ago (2015-05-27 15:44:50 UTC) #6
mstensho (USE GERRIT)
Thanks. Looks like I need moar l-g-t-m, though. Adding mkwst.
5 years, 7 months ago (2015-05-27 16:14:04 UTC) #8
Mike West
Dropping the member from IPC LGTM.
5 years, 6 months ago (2015-05-28 06:17:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150663003/1
5 years, 6 months ago (2015-05-28 10:49:39 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-28 12:06:11 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 12:06:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf3c13e6562ee31f777944bae2461bac87d6ca9f
Cr-Commit-Position: refs/heads/master@{#331767}

Powered by Google App Engine
This is Rietveld 408576698