Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1150623004: Fix names in named parameter lists (Closed)

Created:
5 years, 7 months ago by Leaf
Modified:
5 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Visibility:
Public.

Description

Fix names in named parameter lists This fixes #195. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/582f8589406db926b3cc060c0b7368dd814a2370

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -115 lines) Patch
M lib/runtime/dart/_interceptors.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/_internal.js View 5 chunks +8 lines, -8 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 4 chunks +4 lines, -4 lines 0 comments Download
M lib/runtime/dart/async.js View 23 chunks +36 lines, -36 lines 0 comments Download
M lib/runtime/dart/collection.js View 12 chunks +20 lines, -20 lines 0 comments Download
M lib/runtime/dart/convert.js View 8 chunks +13 lines, -13 lines 0 comments Download
M lib/runtime/dart/core.js View 13 chunks +24 lines, -24 lines 0 comments Download
M lib/runtime/dart/isolate.js View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/sunflower/dom.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/temps.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Leaf
5 years, 7 months ago (2015-05-21 22:01:36 UTC) #2
vsm
lgtm
5 years, 7 months ago (2015-05-21 22:02:45 UTC) #3
Leaf
5 years, 7 months ago (2015-05-21 22:04:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
582f8589406db926b3cc060c0b7368dd814a2370 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698