Hi, Simply i modified *.idl. Because, it which is c++ methods named {Element::blur and Element::focus} ...
4 years, 11 months ago
(2015-06-06 09:28:52 UTC)
#2
Hi, Simply i modified *.idl. Because, it which is c++ methods named
{Element::blur and Element::focus} is being used in common.
hyunjunekim2
Does it need to split methods on c++ methods level?
4 years, 11 months ago
(2015-06-06 09:36:12 UTC)
#3
Does it need to split methods on c++ methods level?
philipj_slow
On 2015/06/06 09:36:12, hyunjunekim2 wrote: > Does it need to split methods on c++ methods ...
4 years, 11 months ago
(2015-06-06 15:10:35 UTC)
#4
On 2015/06/06 09:36:12, hyunjunekim2 wrote:
> Does it need to split methods on c++ methods level?
No, I think it's fine to leave it in Element in the implementation, at least
until we've seen that this change doesn't cause any trouble. You'll just have to
update the test expectations of webexposed/global-interface-listing.html and
virtual/stable/webexposed/global-interface-listing.html and then this will be
ready to land.
hyunjunekim2
On 2015/06/06 15:10:35, philipj wrote: > On 2015/06/06 09:36:12, hyunjunekim2 wrote: > > Does it ...
4 years, 10 months ago
(2015-06-07 02:55:41 UTC)
#5
On 2015/06/06 15:10:35, philipj wrote:
> On 2015/06/06 09:36:12, hyunjunekim2 wrote:
> > Does it need to split methods on c++ methods level?
>
> No, I think it's fine to leave it in Element in the implementation, at least
> until we've seen that this change doesn't cause any trouble. You'll just have
to
> update the test expectations of webexposed/global-interface-listing.html and
> virtual/stable/webexposed/global-interface-listing.html and then this will be
> ready to land.
philipj, i checked gecko's SVGElement.webidl. But no exist {focus, blur} method.
+https://github.com/mozilla/gecko-dev/blob/master/dom/webidl/SVGElement.webidl
and in the inspector of IE11, also checked.
like this,
=== js code ===
var p = SVGElement.prototype;
p.focus // not found.
p.blur // not found.
===============
philipj_slow
On 2015/06/07 02:55:41, hyunjunekim2 wrote: > On 2015/06/06 15:10:35, philipj wrote: > > On 2015/06/06 ...
4 years, 10 months ago
(2015-06-07 07:22:42 UTC)
#6
On 2015/06/07 02:55:41, hyunjunekim2 wrote:
> On 2015/06/06 15:10:35, philipj wrote:
> > On 2015/06/06 09:36:12, hyunjunekim2 wrote:
> > > Does it need to split methods on c++ methods level?
> >
> > No, I think it's fine to leave it in Element in the implementation, at least
> > until we've seen that this change doesn't cause any trouble. You'll just
have
> to
> > update the test expectations of webexposed/global-interface-listing.html and
> > virtual/stable/webexposed/global-interface-listing.html and then this will
be
> > ready to land.
>
> philipj, i checked gecko's SVGElement.webidl. But no exist {focus, blur}
method.
> +https://github.com/mozilla/gecko-dev/blob/master/dom/webidl/SVGElement.webidl
> and in the inspector of IE11, also checked.
> like this,
> === js code ===
> var p = SVGElement.prototype;
> p.focus // not found.
> p.blur // not found.
> ===============
Yep, that matches my findings.
hyunjunekim2
I am going to rebase it.
4 years, 10 months ago
(2015-06-08 00:43:14 UTC)
#7
I am going to rebase it.
hyunjunekim2
philipj, Could you check this patch? Thank you.
4 years, 10 months ago
(2015-06-08 14:08:06 UTC)
#8
philipj, Could you check this patch? Thank you.
philipj_slow
I've double-checked that there is in fact some SVGElement which can be focused with this ...
4 years, 10 months ago
(2015-06-08 21:44:10 UTC)
#9
I've double-checked that there is in fact some SVGElement which can be focused
with this API, and there is: SVGAElement, in this test case:
<!DOCTYPE html>
<svg><a tabindex=1></a></svg>
<script>
document.querySelector('a').focus();
alert(document.activeElement);
</script>
philipj_slow
This LGTM. pdr@, what do you think we should do with small web-facing likely-safe changes ...
4 years, 10 months ago
(2015-06-08 21:45:19 UTC)
#10
This LGTM. pdr@, what do you think we should do with small web-facing
likely-safe changes like this? Just land them, or what amount of paperwork is
appropriate?
pdr.
On 2015/06/08 at 21:45:19, philipj wrote: > This LGTM. pdr@, what do you think we ...
4 years, 10 months ago
(2015-06-08 22:09:56 UTC)
#11
On 2015/06/08 at 21:45:19, philipj wrote:
> This LGTM. pdr@, what do you think we should do with small web-facing
likely-safe changes like this? Just land them, or what amount of paperwork is
appropriate?
I think this is fine. At some level, most bugfixes are web-facing :)
LGTM
philipj_slow
The CQ bit was checked by philipj@opera.com
4 years, 10 months ago
(2015-06-08 22:24:10 UTC)
#12
Issue 1150573004: Move Element.focus()/blur() to HTMLElement and SVGElement.
(Closed)
Created 4 years, 11 months ago by hyunjunekim2
Modified 4 years, 10 months ago
Reviewers: philipj_slow, pdr., fs
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 0
Chromium Code Reviews
