Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1150573004: Move Element.focus()/blur() to HTMLElement and SVGElement. (Closed)

Created:
5 years, 6 months ago by hyunjunekim2
Modified:
5 years, 6 months ago
Reviewers:
pdr., philipj_slow, fs
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, fs, kouhei+svg_chromium.org, vivekg, dglazkov+blink, krit, f(malita), Inactive, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move Element.focus()/blur() to HTMLElement and SVGElement. focus() and blur() are on HTMLElement and SVGElement separately. https://html.spec.whatwg.org/#htmlelement http://www.w3.org/TR/SVG2/types.html#InterfaceSVGElement BUG=497274 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196708

Patch Set 1 #

Patch Set 2 : Draft #

Patch Set 3 : PS 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 3 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 3 chunks +4 lines, -2 lines 0 comments Download
M Source/core/dom/Element.idl View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/HTMLElement.idl View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGElement.idl View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (2 generated)
hyunjunekim2
Hi, Simply i modified *.idl. Because, it which is c++ methods named {Element::blur and Element::focus} ...
5 years, 6 months ago (2015-06-06 09:28:52 UTC) #2
hyunjunekim2
Does it need to split methods on c++ methods level?
5 years, 6 months ago (2015-06-06 09:36:12 UTC) #3
philipj_slow
On 2015/06/06 09:36:12, hyunjunekim2 wrote: > Does it need to split methods on c++ methods ...
5 years, 6 months ago (2015-06-06 15:10:35 UTC) #4
hyunjunekim2
On 2015/06/06 15:10:35, philipj wrote: > On 2015/06/06 09:36:12, hyunjunekim2 wrote: > > Does it ...
5 years, 6 months ago (2015-06-07 02:55:41 UTC) #5
philipj_slow
On 2015/06/07 02:55:41, hyunjunekim2 wrote: > On 2015/06/06 15:10:35, philipj wrote: > > On 2015/06/06 ...
5 years, 6 months ago (2015-06-07 07:22:42 UTC) #6
hyunjunekim2
I am going to rebase it.
5 years, 6 months ago (2015-06-08 00:43:14 UTC) #7
hyunjunekim2
philipj, Could you check this patch? Thank you.
5 years, 6 months ago (2015-06-08 14:08:06 UTC) #8
philipj_slow
I've double-checked that there is in fact some SVGElement which can be focused with this ...
5 years, 6 months ago (2015-06-08 21:44:10 UTC) #9
philipj_slow
This LGTM. pdr@, what do you think we should do with small web-facing likely-safe changes ...
5 years, 6 months ago (2015-06-08 21:45:19 UTC) #10
pdr.
On 2015/06/08 at 21:45:19, philipj wrote: > This LGTM. pdr@, what do you think we ...
5 years, 6 months ago (2015-06-08 22:09:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150573004/40001
5 years, 6 months ago (2015-06-08 22:24:48 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 23:34:22 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196708

Powered by Google App Engine
This is Rietveld 408576698