Do not grant permissions to extensions that come in via Sync disabled due to a permission increase

Do *not* grant permissions to extensions that come in via Sync disabled due to a permission increase.

Follow-up to http://crrev.com/1136543003

BUG=484214
Committed: https://crrev.com/69a7e01be5a9b9802646a812401c5688b9ea21a4
Cr-Commit-Position: refs/heads/master@{#330921}

[Marc Treib, 2015-05-20 09:33:29]

treib@chromium.org changed reviewers:
+ kalman@chromium.org

[Marc Treib, 2015-05-20 09:33:29]

Part 2 :)
PTAL!

[not at google - send to devlin, 2015-05-20 20:21:51]

lgtm

https://codereview.chromium.org/1150573002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_service_unittest.cc (right):

https://codereview.chromium.org/1150573002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_service_unittest.cc:6544: std::string name; 
// For failure output only.
(my initial reaction is that this can be a const char* but it really doesn't
matter either way; the nice thing about const char* is that it's entirely a
struct of primitive types, and that's appealing for no particular reason)

https://codereview.chromium.org/1150573002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_service_unittest.cc:6548: bool
expect_permissions_granted;
these could do with some comments to help interpret the test

[Marc Treib, 2015-05-21 08:37:25]

https://codereview.chromium.org/1150573002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_service_unittest.cc (right):

https://codereview.chromium.org/1150573002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_service_unittest.cc:6544: std::string name; 
// For failure output only.
On 2015/05/20 20:21:51, kalman wrote:
> (my initial reaction is that this can be a const char* but it really doesn't
> matter either way; the nice thing about const char* is that it's entirely a
> struct of primitive types, and that's appealing for no particular reason)

Done.

https://codereview.chromium.org/1150573002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_service_unittest.cc:6548: bool
expect_permissions_granted;
On 2015/05/20 20:21:51, kalman wrote:
> these could do with some comments to help interpret the test

Done.

[Marc Treib, 2015-05-21 08:37:48]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2015-05-21 08:37:48]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1150573002/#ps60001
(title: "review")

[commit-bot: I haz the power, 2015-05-21 08:37:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1150573002/60001

[commit-bot: I haz the power, 2015-05-21 09:38:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-21 09:38:49]

Patchset 4 (id:??) landed as
https://crrev.com/69a7e01be5a9b9802646a812401c5688b9ea21a4
Cr-Commit-Position: refs/heads/master@{#330921}