tools/task_kill.py - Issue 1150543004: Don't fail taskkill on chrome processes alive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/task_kill.py

Issue 1150543004: Don't fail taskkill on chrome processes alive (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/task_kill.py

diff --git a/tools/task_kill.py b/tools/task_kill.py

index 457e45f539cddc80cbc75c1057ea89ef90a2a7f2..a0911649130a6b725f12b37724ac911bea90b792 100755

--- a/tools/task_kill.py

+++ b/tools/task_kill.py

@@ -172,7 +172,9 @@ def Kill(name):

def KillBrowsers():

status = Kill('firefox')

- status += Kill('chrome')

+ # We don't give error on killing chrome. It happens quite often that the

+ # browser controller fails in killing chrome, so we silently do it here.

+ Kill('chrome')

status += Kill('iexplore')

status += Kill('safari')

status += Kill('content_shell')

« no previous file with comments | « no previous file | no next file » | no next file with comments »