Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: content/renderer/media/rtc_video_decoder.h

Issue 1150543002: RtcVideoDecoder: fall back to SW decode for unsupported profiles/resolutions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix rtcvd unittest Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/rtc_video_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/rtc_video_decoder.h
diff --git a/content/renderer/media/rtc_video_decoder.h b/content/renderer/media/rtc_video_decoder.h
index 29adee642e687c14f4a0222ea4171848a3717b73..8bfcc7cd999bc3c83fc94eda742f290157867ada 100644
--- a/content/renderer/media/rtc_video_decoder.h
+++ b/content/renderer/media/rtc_video_decoder.h
@@ -177,6 +177,11 @@ class CONTENT_EXPORT RTCVideoDecoder
// Assert the contract that this class is operated on the right thread.
void DCheckGpuVideoAcceleratorFactoriesTaskRunnerIsCurrent() const;
+ // Query factories_ whether |profile| is supported and return true is so,
+ // false otherwise. If true, also set resolution limits for |profile|
+ // in min/max_resolution_.
+ bool IsProfileSupported(media::VideoCodecProfile profile);
+
enum State {
UNINITIALIZED, // The decoder has not initialized.
INITIALIZED, // The decoder has initialized.
@@ -257,6 +262,10 @@ class CONTENT_EXPORT RTCVideoDecoder
// Release has been called. Guarded by |lock_|.
int32 reset_bitstream_buffer_id_;
+ // Minimum and maximum supported resolutions for the current profile/VDA.
+ gfx::Size min_resolution_;
+ gfx::Size max_resolution_;
+
// Must be destroyed, or invalidated, on |vda_loop_proxy_|
// NOTE: Weak pointers must be invalidated before all other member variables.
base::WeakPtrFactory<RTCVideoDecoder> weak_factory_;
« no previous file with comments | « no previous file | content/renderer/media/rtc_video_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698