Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1150473002: Remove watchers spam from log. (Closed)

Created:
5 years, 7 months ago by mtomasz
Modified:
5 years, 7 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove watchers spam from log. Not supporting file watchers is not an error. It's expected from eg. file systems exposed via File System Provider API, especially those which are read only. TEST=Tested manually that watchers work and there is no spam in the log. BUG=461735 Committed: https://crrev.com/848cef8863832443e796a9ea2deb7e4c58012e7f Cr-Commit-Position: refs/heads/master@{#330697}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -70 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_model.js View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_watcher.js View 1 2 chunks +60 lines, -67 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mtomasz
@yawano: PTAL. Thanks.
5 years, 7 months ago (2015-05-20 01:19:53 UTC) #2
yawano
lgtm. https://codereview.chromium.org/1150473002/diff/1/ui/file_manager/file_manager/foreground/js/file_watcher.js File ui/file_manager/file_manager/foreground/js/file_watcher.js (right): https://codereview.chromium.org/1150473002/diff/1/ui/file_manager/file_manager/foreground/js/file_watcher.js#newcode74 ui/file_manager/file_manager/foreground/js/file_watcher.js:74: * @return {Promise} nit: !Promise https://codereview.chromium.org/1150473002/diff/1/ui/file_manager/file_manager/foreground/js/file_watcher.js#newcode84 ui/file_manager/file_manager/foreground/js/file_watcher.js:84: * ...
5 years, 7 months ago (2015-05-20 02:27:18 UTC) #3
mtomasz
https://codereview.chromium.org/1150473002/diff/1/ui/file_manager/file_manager/foreground/js/file_watcher.js File ui/file_manager/file_manager/foreground/js/file_watcher.js (right): https://codereview.chromium.org/1150473002/diff/1/ui/file_manager/file_manager/foreground/js/file_watcher.js#newcode74 ui/file_manager/file_manager/foreground/js/file_watcher.js:74: * @return {Promise} On 2015/05/20 02:27:18, yawano wrote: > ...
5 years, 7 months ago (2015-05-20 04:21:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150473002/20001
5 years, 7 months ago (2015-05-20 04:22:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-20 04:50:36 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 04:52:31 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/848cef8863832443e796a9ea2deb7e4c58012e7f
Cr-Commit-Position: refs/heads/master@{#330697}

Powered by Google App Engine
This is Rietveld 408576698