Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1150433002: Add library names to many sky libraries (Closed)

Created:
5 years, 7 months ago by Cutch
Modified:
5 years, 7 months ago
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@fix_shelldb
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add library names to many sky libraries - Analyzer complains about libraries not having names. This adds names to many libraries.

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -1 line) Patch
M sky/examples/stocks/lib/stock_arrow.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/examples/stocks/lib/stock_data.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/examples/stocks/lib/stock_list.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/animation/animated_value.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/animation/curves.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/animation/generators.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/animation/mechanics.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/animation/scroll_behavior.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/action_bar.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/animated_component.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/button.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/button_base.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/checkbox.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/drawer.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/drawer_header.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/fixed_height_scrollable.dart View 2 chunks +3 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/components/floating_action_button.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/icon.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/icon_button.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/ink_splash.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/ink_well.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/input.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/material.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/menu_divider.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/menu_item.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/modal_overlay.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/popup_menu.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/popup_menu_item.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/radio.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/scaffold.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components/scrollable.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/debug/tracing.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/editing/editable_string.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/editing/editable_text.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/editing/keyboard.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/theme/colors.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/theme/typography.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Cutch
5 years, 7 months ago (2015-05-19 17:10:10 UTC) #2
Cutch
5 years, 7 months ago (2015-05-19 17:11:20 UTC) #3
eseidel
Please make a note to dartbug.com/22836 in your changelog. These really shouldn't be necessary. but ...
5 years, 7 months ago (2015-05-19 17:13:20 UTC) #4
abarth-chromium
not lgtm I don't think we should add this boilerplate to this files for the ...
5 years, 7 months ago (2015-05-19 17:19:15 UTC) #6
Cutch
5 years, 7 months ago (2015-05-19 17:19:17 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
1337e0a803a54ee92d6dce7f8c4a6335f7cbb9fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698