Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 11504002: Bookmark manager: make Organized menu commands to work. (Closed)

Created:
8 years ago by yosin_UTC9
Modified:
8 years ago
CC:
chromium-reviews, arv (Not doing code reviews), yoichio, kenjibaheux
Visibility:
Public.

Description

Since rev 167360, change focus handling for a11y, list view and tree view aren't active element when executing command from [Organized] menu. This patch changes to use global variable |list| instead of document.activeElement if activeElement isn't tree view. * list 'canExecute' event handler: Changed to call canExecuteForList(). * canExecuteForList(): Copied list 'canExecute' event handler and to use |list|. * organizeButton 'canExecute' event handler: Update sort-command canExecute even if canEdit isn't changed. * document 'command' event handler: Changed to call handleCommand() * getSelectedBoomarkNodes(): Changed to handle activeElement is neither list or tree. * handleCommand(): Changed to handle all commands rather than list and tree context menus. BUG=165075 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172230

Patch Set 1 : 2012-12-10T15:50 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -72 lines) Patch
M chrome/browser/resources/bookmark_manager/js/main.js View 12 chunks +40 lines, -72 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
yosin_UTC9
Hi Eric, Could you review this patch? Thanks in advance.
8 years ago (2012-12-10 05:12:01 UTC) #1
arv (Not doing code reviews)
8 years ago (2012-12-10 19:59:16 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698