chrome/browser/chromeos/platform_keys/key_permissions_policy_handlers.h - Issue 1150373002: platformKeys: Add policy and corporate key tagging.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chromeos/platform_keys/key_permissions_policy_handlers.h

Issue 1150373002: platformKeys: Add policy and corporate key tagging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@key_perm

Patch Set: Rebased. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/chromeos/platform_keys/key_permissions.cc ('k') | chrome/browser/chromeos/platform_keys/key_permissions_policy_handlers.cc » ('j') | chrome/browser/chromeos/platform_keys/key_permissions_policy_handlers.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_CHROMEOS_PLATFORM_KEYS_KEY_PERMISSIONS_POLICY_HANDLERS_H_
	bartfab (slow) 2015/06/15 17:28:15 Nit: Why is the file name in the plural (handlers Nit: Why is the file name in the plural (handlers)? pneubeck (no reviews)* 2015/06/17 08:59:56 Done. Show quoted text On 2015/06/15 17:28:15, bartfab wrote: > Nit: Why is the file name in the plural (handlers)? Done.
	6 #define CHROME_BROWSER_CHROMEOS_PLATFORM_KEYS_KEY_PERMISSIONS_POLICY_HANDLERS_H_

	7

	8 #include "base/memory/scoped_ptr.h"
	bartfab (slow) 2015/06/15 17:28:15 Nit: Not used. Nit: Not used. pneubeck (no reviews) 2015/06/17 08:59:56 Done. Show quoted text On 2015/06/15 17:28:15, bartfab wrote: > Nit: Not used. Done.
	9 #include "base/values.h"
	bartfab (slow) 2015/06/15 17:28:15 Nit: Not used. Nit: Not used. pneubeck (no reviews) 2015/06/17 08:59:56 Done. Show quoted text On 2015/06/15 17:28:15, bartfab wrote: > Nit: Not used. Done.
	10 #include "components/policy/core/browser/configuration_policy_handler.h"

	11

	12 namespace chromeos {

	13

	14 class KeyPermissionsPolicyHandler

	15 : public policy::SchemaValidatingPolicyHandler {

	16 public:

	17 explicit KeyPermissionsPolicyHandler(const policy::Schema& chrome_schema);
	bartfab (slow) 2015/06/15 17:28:15 Nit: Forward-declare \|policy::Schema\|. Nit: Forward-declare \|policy::Schema\|. pneubeck (no reviews) 2015/06/17 08:59:56 Done. Show quoted text On 2015/06/15 17:28:15, bartfab wrote: > Nit: Forward-declare \|policy::Schema\|. Done.
	18 ~KeyPermissionsPolicyHandler() override;
	bartfab (slow) 2015/06/15 17:28:15 Nit: No need to override the destructor here. Nit: No need to override the destructor here. pneubeck (no reviews) 2015/06/17 08:59:56 Done. Show quoted text On 2015/06/15 17:28:15, bartfab wrote: > Nit: No need to override the destructor here. Done.
	19

	20 // ConfigurationPolicyHandler:
	bartfab (slow) 2015/06/15 17:28:15 Nit: s\|// \|// policy::\| Nit: s\|// \|// policy::\| pneubeck (no reviews) 2015/06/17 08:59:56 Done. Show quoted text On 2015/06/15 17:28:15, bartfab wrote: > Nit: s\|// \|// policy::\| Done.
	21 void ApplyPolicySettings(const policy::PolicyMap& policies,

	22 PrefValueMap* prefs) override;

	23

	24 private:

	25 DISALLOW_COPY_AND_ASSIGN(KeyPermissionsPolicyHandler);
	bartfab (slow) 2015/06/15 17:28:15 Nit: #include "base/macros.h" Nit: #include "base/macros.h" pneubeck (no reviews) 2015/06/17 08:59:56 Done. Show quoted text On 2015/06/15 17:28:15, bartfab wrote: > Nit: #include "base/macros.h" Done.
	26 };

	27

	28 } // namespace chromeos

	29

	30 #endif // CHROME_BROWSER_CHROMEOS_PLATFORM_KEYS_KEY_PERMISSIONS_POLICY_HANDLERS _H_

OLD	NEW