Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

Issue 1150343004: Changing string id for CONTENT_SETTINGS_TYPE_COOKIES for block and allow case. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc b/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
index 961332f9d7ecc6da90ee4b189900f3600969b353..dab8d7424a9548a0bcf3ca1c6d7bfab007037f55 100644
--- a/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
@@ -115,9 +115,8 @@ TEST_F(ContentSettingBubbleModelTest, Cookies) {
EXPECT_FALSE(bubble_content_2.title.empty());
EXPECT_NE(title, bubble_content_2.title);
ASSERT_EQ(2U, bubble_content_2.radio_group.radio_items.size());
- // TODO(bauerb): Update this once the strings have been updated.
- EXPECT_EQ(radio1, bubble_content_2.radio_group.radio_items[0]);
- EXPECT_EQ(radio2, bubble_content_2.radio_group.radio_items[1]);
+ EXPECT_NE(radio1, bubble_content_2.radio_group.radio_items[0]);
Bernhard Bauer 2015/06/05 14:23:46 Can we update this test so it tests something more
Deepak 2015/06/08 05:53:31 Done.
+ EXPECT_NE(radio2, bubble_content_2.radio_group.radio_items[1]);
EXPECT_FALSE(bubble_content_2.custom_link.empty());
EXPECT_TRUE(bubble_content_2.custom_link_enabled);
EXPECT_FALSE(bubble_content_2.manage_link.empty());

Powered by Google App Engine
This is Rietveld 408576698