Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1150333002: Use OAuth for accessing Rietveld (Closed)

Created:
5 years, 7 months ago by Sergiy Byelozyorov
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use OAuth for accessing Rietveld R=machenbach@chromium.org, tandrii@chromium.org BUG=489483 LOG=n NOTRY=true Committed: https://crrev.com/4aeeb0170244bf63f0b57aa3ee5a0fca4431b9e7 Cr-Commit-Position: refs/heads/master@{#28602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/commit_queue/config.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Sergiy Byelozyorov
5 years, 7 months ago (2015-05-22 16:03:50 UTC) #1
Sergiy Byelozyorov
Please check CQ bit once you've lgtm'd it. This is urgent and must land before ...
5 years, 7 months ago (2015-05-22 17:48:09 UTC) #3
tandrii(chromium)
lgtm
5 years, 7 months ago (2015-05-22 17:58:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150333002/1
5 years, 7 months ago (2015-05-22 17:59:03 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-22 17:59:05 UTC) #8
Michael Achenbach
lgtm
5 years, 7 months ago (2015-05-22 18:44:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150333002/1
5 years, 7 months ago (2015-05-22 18:45:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-22 18:48:47 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 18:49:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4aeeb0170244bf63f0b57aa3ee5a0fca4431b9e7
Cr-Commit-Position: refs/heads/master@{#28602}

Powered by Google App Engine
This is Rietveld 408576698