Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: src/mips64/full-codegen-mips64.cc

Issue 1150323002: Move work to omit unnecessary ObjectLiteral stores to the numbering pass. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 1642 matching lines...) Expand 10 before | Expand all | Expand 10 after
1653 } else { 1653 } else {
1654 FastCloneShallowObjectStub stub(isolate(), expr->properties_count()); 1654 FastCloneShallowObjectStub stub(isolate(), expr->properties_count());
1655 __ CallStub(&stub); 1655 __ CallStub(&stub);
1656 } 1656 }
1657 PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG); 1657 PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG);
1658 1658
1659 // If result_saved is true the result is on top of the stack. If 1659 // If result_saved is true the result is on top of the stack. If
1660 // result_saved is false the result is in v0. 1660 // result_saved is false the result is in v0.
1661 bool result_saved = false; 1661 bool result_saved = false;
1662 1662
1663 // Mark all computed expressions that are bound to a key that
1664 // is shadowed by a later occurrence of the same key. For the
1665 // marked expressions, no store code is emitted.
1666 expr->CalculateEmitStore(zone());
1667
1668 AccessorTable accessor_table(zone()); 1663 AccessorTable accessor_table(zone());
1669 int property_index = 0; 1664 int property_index = 0;
1670 for (; property_index < expr->properties()->length(); property_index++) { 1665 for (; property_index < expr->properties()->length(); property_index++) {
1671 ObjectLiteral::Property* property = expr->properties()->at(property_index); 1666 ObjectLiteral::Property* property = expr->properties()->at(property_index);
1672 if (property->is_computed_name()) break; 1667 if (property->is_computed_name()) break;
1673 if (property->IsCompileTimeValue()) continue; 1668 if (property->IsCompileTimeValue()) continue;
1674 1669
1675 Literal* key = property->key()->AsLiteral(); 1670 Literal* key = property->key()->AsLiteral();
1676 Expression* value = property->value(); 1671 Expression* value = property->value();
1677 if (!result_saved) { 1672 if (!result_saved) {
(...skipping 3793 matching lines...) Expand 10 before | Expand all | Expand 10 after
5471 Assembler::target_address_at(pc_immediate_load_address)) == 5466 Assembler::target_address_at(pc_immediate_load_address)) ==
5472 reinterpret_cast<uint64_t>( 5467 reinterpret_cast<uint64_t>(
5473 isolate->builtins()->OsrAfterStackCheck()->entry())); 5468 isolate->builtins()->OsrAfterStackCheck()->entry()));
5474 return OSR_AFTER_STACK_CHECK; 5469 return OSR_AFTER_STACK_CHECK;
5475 } 5470 }
5476 5471
5477 5472
5478 } } // namespace v8::internal 5473 } } // namespace v8::internal
5479 5474
5480 #endif // V8_TARGET_ARCH_MIPS64 5475 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698