Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 1150323002: Move work to omit unnecessary ObjectLiteral stores to the numbering pass. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/hydrogen.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1593 matching lines...) Expand 10 before | Expand all | Expand 10 after
1604 __ mov(edx, Immediate(Smi::FromInt(flags))); 1604 __ mov(edx, Immediate(Smi::FromInt(flags)));
1605 FastCloneShallowObjectStub stub(isolate(), expr->properties_count()); 1605 FastCloneShallowObjectStub stub(isolate(), expr->properties_count());
1606 __ CallStub(&stub); 1606 __ CallStub(&stub);
1607 } 1607 }
1608 PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG); 1608 PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG);
1609 1609
1610 // If result_saved is true the result is on top of the stack. If 1610 // If result_saved is true the result is on top of the stack. If
1611 // result_saved is false the result is in eax. 1611 // result_saved is false the result is in eax.
1612 bool result_saved = false; 1612 bool result_saved = false;
1613 1613
1614 // Mark all computed expressions that are bound to a key that
1615 // is shadowed by a later occurrence of the same key. For the
1616 // marked expressions, no store code is emitted.
1617 expr->CalculateEmitStore(zone());
1618
1619 AccessorTable accessor_table(zone()); 1614 AccessorTable accessor_table(zone());
1620 int property_index = 0; 1615 int property_index = 0;
1621 for (; property_index < expr->properties()->length(); property_index++) { 1616 for (; property_index < expr->properties()->length(); property_index++) {
1622 ObjectLiteral::Property* property = expr->properties()->at(property_index); 1617 ObjectLiteral::Property* property = expr->properties()->at(property_index);
1623 if (property->is_computed_name()) break; 1618 if (property->is_computed_name()) break;
1624 if (property->IsCompileTimeValue()) continue; 1619 if (property->IsCompileTimeValue()) continue;
1625 1620
1626 Literal* key = property->key()->AsLiteral(); 1621 Literal* key = property->key()->AsLiteral();
1627 Expression* value = property->value(); 1622 Expression* value = property->value();
1628 if (!result_saved) { 1623 if (!result_saved) {
(...skipping 3759 matching lines...) Expand 10 before | Expand all | Expand 10 after
5388 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5383 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5389 Assembler::target_address_at(call_target_address, 5384 Assembler::target_address_at(call_target_address,
5390 unoptimized_code)); 5385 unoptimized_code));
5391 return OSR_AFTER_STACK_CHECK; 5386 return OSR_AFTER_STACK_CHECK;
5392 } 5387 }
5393 5388
5394 5389
5395 } } // namespace v8::internal 5390 } } // namespace v8::internal
5396 5391
5397 #endif // V8_TARGET_ARCH_IA32 5392 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698