Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 1150313003: Move Sk4px Xfermode code to a header so we can use it twice. (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
f(malita), mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move Sk4px Xfermode code to a header so we can use it twice. - Once in SkXfermode as usual to pick up compile-time SSE and NEON - Once in SkXfermode_arm_neon to pick up run-time NEON This allows us to start cleaning up SkXfermode_arm_neon as we've done for SkXfermode_SSE2. I'm saving this catharsis for a day when I need it. The Sk4px xfermodes are generally faster than the existing NEON procs, so this should also have the side effect of a perf win there. This means our new Plus-AA code works for runtime NEON too. BUG=skia:3852 Committed: https://skia.googlesource.com/skia/+/27c2b09374bb97dfc3a0ab270490209747b91a64

Patch Set 1 #

Patch Set 2 : wrong date #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -146 lines) Patch
A src/core/Sk4pxXfermode.h View 1 1 chunk +156 lines, -0 lines 0 comments Download
M src/core/SkXfermode.cpp View 4 chunks +3 lines, -141 lines 0 comments Download
M src/opts/SkXfermode_opts_arm_neon.cpp View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 7 months ago (2015-05-22 17:36:08 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150313003/20001
5 years, 7 months ago (2015-05-22 17:36:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-22 17:42:36 UTC) #6
f(malita)
LGTM
5 years, 7 months ago (2015-05-22 17:53:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150313003/20001
5 years, 7 months ago (2015-05-22 17:54:05 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 17:54:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/27c2b09374bb97dfc3a0ab270490209747b91a64

Powered by Google App Engine
This is Rietveld 408576698