[Reland] Setup LayoutMenuList to not modify layout tree outside style recalc.

[Reland] Setup LayoutMenuList to not modify layout tree outside style recalc.

This CL updates the LayoutMenuList code to not modify the layout
tree ourside of style recalc. The way this is done is, instead of creating
and destroying LayoutText or LayoutBR elements it just uses
LayoutText elements and sets the blank string into them when
it would have used LayoutBR previously.

This CL was originally landed in r195671 but was reverted in r195695 due to
breaking Android accessiblity tests during the blink roll. The two broken tests
were:
 * DumpAccessibilityTreeTest.AccessibilityOptgroup
 * DumpAccessibilityTreeTest.AccessibilitySelect

Those tests have been marked as skip, needs rebaseline in
https://crrev.com/20d41b01d06a8420829a9406eaee773e11239c78
so this should be safe to reland.

BUG=370462
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195803

[dsinclair, 2015-05-22 17:03:49]

dsinclair@chromium.org changed reviewers:
+ jchaffraix@chromium.org

[dsinclair, 2015-05-22 17:03:49]

PTAL.

The offending tests have been disabled, you can see in the linux_android_rel_ng
tests. The failed run was before the test were disabled, the next run is with
the disable, content_browsertests successfully passed.

[dsinclair, 2015-05-22 17:06:16]

dsinclair@chromium.org changed reviewers:
+ eae@chromium.org, leviw@chromium.org

[pdr., 2015-05-22 17:22:30]

LGTM

[dsinclair, 2015-05-22 17:22:50]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2015-05-22 17:23:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1150303003/1

[commit-bot: I haz the power, 2015-05-22 18:45:58]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195803

[tkent, 2015-05-25 00:59:08]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1152623003/ by tkent@chromium.org.

The reason for reverting is: Broke the following tests on Mac:
AutomationApiTest.Mixins
BrowserTest.CancelBeforeUnloadResetsURL
NaClBrowserTestPnacl.PnaclExceptionHandlingDisabled
PasswordManagerBrowserTest.NoPromptForFailedLoginFromSubFrameWithMultiFramesInPage
.

[tkent, 2015-05-25 01:00:39]

On 2015/05/25 00:59:08, tkent wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1152623003/ by mailto:tkent@chromium.org.
> 
> The reason for reverting is: Broke the following tests on Mac:
> AutomationApiTest.Mixins
> BrowserTest.CancelBeforeUnloadResetsURL
> NaClBrowserTestPnacl.PnaclExceptionHandlingDisabled
>
PasswordManagerBrowserTest.NoPromptForFailedLoginFromSubFrameWithMultiFramesInPage
> .

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=Aut...
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=Bro...
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=NaC...
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=Pas...

[dsinclair, 2015-05-25 02:31:28]

On 2015/05/25 at 01:00:39, tkent wrote:
> On 2015/05/25 00:59:08, tkent wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/1152623003/ by mailto:tkent@chromium.org.
> > 
> > The reason for reverting is: Broke the following tests on Mac:
> > AutomationApiTest.Mixins
> > BrowserTest.CancelBeforeUnloadResetsURL
> > NaClBrowserTestPnacl.PnaclExceptionHandlingDisabled
> >
PasswordManagerBrowserTest.NoPromptForFailedLoginFromSubFrameWithMultiFramesInPage
> > .
> 
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=Aut...
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=Bro...
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=NaC...
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=Pas...


I'm a bit confused, did it break the test or is the test flaky now? For the last
three of those links, I don't see this CL in the blame range? Is this revert
speculative or can you link me to the failed runs it's referring too?

[tkent, 2015-05-25 08:03:01]

On 2015/05/25 02:31:28, dsinclair wrote:
> On 2015/05/25 at 01:00:39, tkent wrote:
> > On 2015/05/25 00:59:08, tkent wrote:
> > > A revert of this CL (patchset #1 id:1) has been created in
> > > https://codereview.chromium.org/1152623003/ by mailto:tkent@chromium.org.
> > > 
> > > The reason for reverting is: Broke the following tests on Mac:
> > > AutomationApiTest.Mixins
> > > BrowserTest.CancelBeforeUnloadResetsURL
> > > NaClBrowserTestPnacl.PnaclExceptionHandlingDisabled
> > >
>
PasswordManagerBrowserTest.NoPromptForFailedLoginFromSubFrameWithMultiFramesInPage
> > > .
> > 
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=Aut...
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=Bro...
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=NaC...
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=Pas...
> 
> 
> I'm a bit confused, did it break the test or is the test flaky now? For the
last
> three of those links, I don't see this CL in the blame range? Is this revert
> speculative or can you link me to the failed runs it's referring too?

The revert didn't fix at least AutomationApiTest.Mixins.  I'll revert the
revert.
I'm sorry for the noise.