cc: Refactor content scale/bounds into draw properties

cc/contents_scaling_layer.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/contents_scaling_layer.h"
 #include "ui/gfx/size_conversions.h"
 
 namespace cc {
 
 gfx::Size ContentsScalingLayer::computeContentBoundsForScale(float scaleX, float scaleY) const {
   return gfx::ToCeiledSize(gfx::ScaleSize(bounds(), scaleX, scaleY));
 }
 
-ContentsScalingLayer::ContentsScalingLayer()
-    : m_contentsScale(1.0) {
+ContentsScalingLayer::ContentsScalingLayer() {
 }
 
 ContentsScalingLayer::~ContentsScalingLayer() {
 }
 
-gfx::Size ContentsScalingLayer::contentBounds() const {
-  return computeContentBoundsForScale(contentsScaleX(), contentsScaleY());
+void ContentsScalingLayer::updateContentsScale(float ideal_contents_scale) {

[danakj, 2012/12/14 20:37:23]

What do you think of making this method just return the actual scale/bounds it
wants to use, and have calcDrawProps set the m_drawProperties itself?

I think I'd like it if all the m_drawProps mutating happened in calcDrawProps or
helper static methods in lthcommon, and everything else treated it as const.

The didUpdateBounds() would be an exception for now.

[enne (OOO), 2012/12/14 22:06:05]

Done.

+  m_drawProperties.contents_scale_x = ideal_contents_scale;
+  m_drawProperties.contents_scale_y = ideal_contents_scale;
+  m_drawProperties.content_bounds = computeContentBoundsForScale(
+      contentsScaleX(),
+      contentsScaleY());
 }
 
-float ContentsScalingLayer::contentsScaleX() const {
-  return m_contentsScale;
-}
-
-float ContentsScalingLayer::contentsScaleY() const {
-  return m_contentsScale;
-}
-
-void ContentsScalingLayer::setContentsScale(float contentsScale) {
-  if (m_contentsScale == contentsScale)
-    return;
-  m_contentsScale = contentsScale;
-  setNeedsDisplay();
+void ContentsScalingLayer::didUpdateBounds() {
+  m_drawProperties.content_bounds = computeContentBoundsForScale(
+      contentsScaleX(),
+      contentsScaleY());
 }
 
 }  // namespace cc