Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 11503003: Merge 136803 (Closed)

Created:
8 years ago by tkent
Modified:
8 years ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 136803 > Source/WebCore: INPUT_MULTIPLE_FIELDS_UI: The hour, am/pm, millisecond fields should support read-only state correctly > https://bugs.webkit.org/show_bug.cgi?id=104210 > > Reviewed by Kentaro Hara. > > 1. The hour, am/pm, and millisecond fields should have CSS rules for > [readonly]. They should be gray when they are read-only. > 2. The am/pm field should reject to set an empty value like other > numeric fields do. > > Tests: Add test cases to fast/forms/time/time-appearance-basic.html. > > * css/html.css: merge existing readonly rules, and add ampm, hour, and > millisecond pseudo classes. > * html/shadow/DateTimeSymbolicFieldElement.cpp: > (WebCore::DateTimeSymbolicFieldElement::setEmptyValue): > Reject to set empty value if it is read-only. > > LayoutTests: INPUT_MULTIPLE_FIELDS_UI: The hour field and the am/pm field should support read-only state correctly > https://bugs.webkit.org/show_bug.cgi?id=104210 > > Reviewed by Kentaro Hara. > > * fast/forms/time/time-appearance-basic.html: > Add test cases for step=86400 (24 hours) > * platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png: > * platform/chromium/TestExpectations: > TBR=tkent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137100

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M LayoutTests/platform/chromium/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/css/html.css View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tkent
8 years ago (2012-12-10 01:08:54 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698