src/full-codegen.cc - Issue 1150293002: Do not leak message object beyond try-catch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen.cc

Issue 1150293002: Do not leak message object beyond try-catch. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: platform ports and turbofan Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen.cc

diff --git a/src/full-codegen.cc b/src/full-codegen.cc

index 4ea455edfe9d2f1ac9c0b4f0109cb69d8297ea24..4e04e8556f7c27c227da0b6d20465a06d307a3a8 100644

--- a/src/full-codegen.cc

+++ b/src/full-codegen.cc

@@ -1182,6 +1182,7 @@ void FullCodeGenerator::VisitTryCatchStatement(TryCatchStatement* stmt) {

Label try_entry, handler_entry, exit;

__ jmp(&try_entry);

__ bind(&handler_entry);

+ EnterCatchBlock();

// Exception handler code, the exception is in the result register.

// Extend the context before executing the catch block.

{ Comment cmnt(masm_, "[ Extend catch context");