Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 1150293002: Do not leak message object beyond try-catch. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: platform ports and turbofan Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 5359 matching lines...) Expand 10 before | Expand all | Expand 10 after
5370 5370
5371 // Uncook return address and return. 5371 // Uncook return address and return.
5372 __ pop(result_register()); 5372 __ pop(result_register());
5373 DCHECK_EQ(1, kSmiTagSize + kSmiShiftSize); 5373 DCHECK_EQ(1, kSmiTagSize + kSmiShiftSize);
5374 __ sra(a1, a1, 1); // Un-smi-tag value. 5374 __ sra(a1, a1, 1); // Un-smi-tag value.
5375 __ Addu(at, a1, Operand(masm_->CodeObject())); 5375 __ Addu(at, a1, Operand(masm_->CodeObject()));
5376 __ Jump(at); 5376 __ Jump(at);
5377 } 5377 }
5378 5378
5379 5379
5380 void FullCodeGenerator::EnterCatchBlock() {
5381 DCHECK(!result_register().is(a1));
5382 ExternalReference pending_message_obj =
5383 ExternalReference::address_of_pending_message_obj(isolate());
5384 __ LoadRoot(a1, Heap::kTheHoleValueRootIndex);
5385 __ li(at, Operand(pending_message_obj));
5386 __ sw(a1, MemOperand(at));
5387 }
5388
5389
5380 #undef __ 5390 #undef __
5381 5391
5382 5392
5383 void BackEdgeTable::PatchAt(Code* unoptimized_code, 5393 void BackEdgeTable::PatchAt(Code* unoptimized_code,
5384 Address pc, 5394 Address pc,
5385 BackEdgeState target_state, 5395 BackEdgeState target_state,
5386 Code* replacement_code) { 5396 Code* replacement_code) {
5387 static const int kInstrSize = Assembler::kInstrSize; 5397 static const int kInstrSize = Assembler::kInstrSize;
5388 Address branch_address = pc - 6 * kInstrSize; 5398 Address branch_address = pc - 6 * kInstrSize;
5389 CodePatcher patcher(branch_address, 1); 5399 CodePatcher patcher(branch_address, 1);
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
5452 Assembler::target_address_at(pc_immediate_load_address)) == 5462 Assembler::target_address_at(pc_immediate_load_address)) ==
5453 reinterpret_cast<uint32_t>( 5463 reinterpret_cast<uint32_t>(
5454 isolate->builtins()->OsrAfterStackCheck()->entry())); 5464 isolate->builtins()->OsrAfterStackCheck()->entry()));
5455 return OSR_AFTER_STACK_CHECK; 5465 return OSR_AFTER_STACK_CHECK;
5456 } 5466 }
5457 5467
5458 5468
5459 } } // namespace v8::internal 5469 } } // namespace v8::internal
5460 5470
5461 #endif // V8_TARGET_ARCH_MIPS 5471 #endif // V8_TARGET_ARCH_MIPS
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698