Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 1150293002: Do not leak message object beyond try-catch. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: platform ports and turbofan Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | src/full-codegen.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 5356 matching lines...) Expand 10 before | Expand all | Expand 10 after
5367 // Restore result register from stack. 5367 // Restore result register from stack.
5368 __ pop(r1); 5368 __ pop(r1);
5369 5369
5370 // Uncook return address and return. 5370 // Uncook return address and return.
5371 __ pop(result_register()); 5371 __ pop(result_register());
5372 __ SmiUntag(r1); 5372 __ SmiUntag(r1);
5373 __ add(pc, r1, Operand(masm_->CodeObject())); 5373 __ add(pc, r1, Operand(masm_->CodeObject()));
5374 } 5374 }
5375 5375
5376 5376
5377 void FullCodeGenerator::EnterCatchBlock() {
5378 DCHECK(!result_register().is(r1));
5379 ExternalReference pending_message_obj =
5380 ExternalReference::address_of_pending_message_obj(isolate());
5381 __ LoadRoot(r1, Heap::kTheHoleValueRootIndex);
5382 __ mov(ip, Operand(pending_message_obj));
5383 __ str(r1, MemOperand(ip));
5384 }
5385
5386
5377 #undef __ 5387 #undef __
5378 5388
5379 5389
5380 static Address GetInterruptImmediateLoadAddress(Address pc) { 5390 static Address GetInterruptImmediateLoadAddress(Address pc) {
5381 Address load_address = pc - 2 * Assembler::kInstrSize; 5391 Address load_address = pc - 2 * Assembler::kInstrSize;
5382 if (!FLAG_enable_ool_constant_pool) { 5392 if (!FLAG_enable_ool_constant_pool) {
5383 DCHECK(Assembler::IsLdrPcImmediateOffset(Memory::int32_at(load_address))); 5393 DCHECK(Assembler::IsLdrPcImmediateOffset(Memory::int32_at(load_address)));
5384 } else if (Assembler::IsLdrPpRegOffset(Memory::int32_at(load_address))) { 5394 } else if (Assembler::IsLdrPpRegOffset(Memory::int32_at(load_address))) {
5385 // This is an extended constant pool lookup. 5395 // This is an extended constant pool lookup.
5386 if (CpuFeatures::IsSupported(ARMv7)) { 5396 if (CpuFeatures::IsSupported(ARMv7)) {
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
5512 5522
5513 DCHECK(interrupt_address == 5523 DCHECK(interrupt_address ==
5514 isolate->builtins()->OsrAfterStackCheck()->entry()); 5524 isolate->builtins()->OsrAfterStackCheck()->entry());
5515 return OSR_AFTER_STACK_CHECK; 5525 return OSR_AFTER_STACK_CHECK;
5516 } 5526 }
5517 5527
5518 5528
5519 } } // namespace v8::internal 5529 } } // namespace v8::internal
5520 5530
5521 #endif // V8_TARGET_ARCH_ARM 5531 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | src/full-codegen.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698