Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1150293002: Do not leak message object beyond try-catch. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not leak message object beyond try-catch. R=mstarzinger@chromium.org Committed: https://crrev.com/14eba9b27531911f8466a5877fc66b64bc98bdb6 Cr-Commit-Position: refs/heads/master@{#28612}

Patch Set 1 #

Patch Set 2 : platform ports and turbofan #

Total comments: 2

Patch Set 3 : also fix try-finally #

Patch Set 4 : fix memory leak by setting flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -0 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M src/full-codegen.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Yang
5 years, 7 months ago (2015-05-22 11:25:58 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150293002/20001
5 years, 7 months ago (2015-05-22 11:56:01 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/4432)
5 years, 7 months ago (2015-05-22 12:24:57 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150293002/20001
5 years, 7 months ago (2015-05-22 12:46:15 UTC) #7
Michael Starzinger
LGTM. I am fine with addressing the comment in a follow-up CL. https://codereview.chromium.org/1150293002/diff/20001/src/full-codegen.h File src/full-codegen.h ...
5 years, 7 months ago (2015-05-22 13:02:29 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/4445)
5 years, 7 months ago (2015-05-22 13:55:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150293002/60001
5 years, 7 months ago (2015-05-26 07:19:05 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-26 08:00:11 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 08:00:28 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/14eba9b27531911f8466a5877fc66b64bc98bdb6
Cr-Commit-Position: refs/heads/master@{#28612}

Powered by Google App Engine
This is Rietveld 408576698