Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: src/runtime.js

Issue 1150263002: JavaScript stubs have access to their calling convention and minor key now. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | test/mjsunit/compiler/stubs/floor-stub.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime.js
diff --git a/src/runtime.js b/src/runtime.js
index 86db49595efc179359048f3f74b45d6925aa478a..d1ebc301fbdbf3c42e70f60fc23900b79d531033 100644
--- a/src/runtime.js
+++ b/src/runtime.js
@@ -64,9 +64,9 @@ var TO_NUMBER;
var TO_STRING;
var TO_NAME;
-var StringLengthTF_STUB;
-var StringAddTF_STUB;
-var MathFloor_STUB;
+var StringLengthTFStub;
+var StringAddTFStub;
+var MathFloorStub;
var $defaultNumber;
var $defaultString;
@@ -767,35 +767,44 @@ TO_NAME = function TO_NAME() {
-----------------------------------------------
*/
-StringLengthTF_STUB = function StringLengthTF_STUB(receiver, name, i, v) {
- // i and v are dummy parameters mandated by the InterfaceDescriptor,
- // (LoadWithVectorDescriptor).
- return %_StringGetLength(%_JSValueGetValue(receiver));
-}
-
-StringAddTF_STUB = function StringAddTF_STUB(left, right) {
- return %StringAdd(left, right);
+StringLengthTFStub = function StringLengthTFStub(call_conv, minor_key) {
+ var stub = function(receiver, name, i, v) {
+ // i and v are dummy parameters mandated by the InterfaceDescriptor,
+ // (LoadWithVectorDescriptor).
+ return %_StringGetLength(%_JSValueGetValue(receiver));
+ }
+ return stub;
}
-MathFloor_STUB = function MathFloor_STUB(f, i, v) {
- // |f| is calling function's JSFunction
- // |i| is TypeFeedbackVector slot # of callee's CallIC for Math.floor call
- // |v| is the value to floor
- var r = %_MathFloor(+v);
- if (%_IsMinusZero(r)) {
- // Collect type feedback when the result of the floor is -0. This is
- // accomplished by storing a sentinel in the second, "extra"
- // TypeFeedbackVector slot corresponding to the Math.floor CallIC call in
- // the caller's TypeVector.
- %_FixedArraySet(%_GetTypeFeedbackVector(f), ((i|0)+1)|0, 1);
- return -0;
+StringAddTFStub = function StringAddTFStub(call_conv, minor_key) {
+ var stub = function(left, right) {
+ return %StringAdd(left, right);
}
- // Return integers in smi range as smis.
- var trunc = r|0;
- if (trunc === r) {
- return trunc;
+ return stub;
+}
+
+MathFloorStub = function MathFloorStub(call_conv, minor_key) {
+ var stub = function(f, i, v) {
+ // |f| is calling function's JSFunction
+ // |i| is TypeFeedbackVector slot # of callee's CallIC for Math.floor call
+ // |v| is the value to floor
+ var r = %_MathFloor(+v);
+ if (%_IsMinusZero(r)) {
+ // Collect type feedback when the result of the floor is -0. This is
+ // accomplished by storing a sentinel in the second, "extra"
+ // TypeFeedbackVector slot corresponding to the Math.floor CallIC call in
+ // the caller's TypeVector.
+ %_FixedArraySet(%_GetTypeFeedbackVector(f), ((i|0)+1)|0, 1);
+ return -0;
+ }
+ // Return integers in smi range as smis.
+ var trunc = r|0;
+ if (trunc === r) {
+ return trunc;
+ }
+ return r;
}
- return r;
+ return stub;
}
« no previous file with comments | « src/code-stubs.cc ('k') | test/mjsunit/compiler/stubs/floor-stub.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698